Switch to ESM modules#808
Merged
Merged
Conversation
Member
Author
|
(I used this ticket to test out auto-mode Claude Code running in a Docker Sandbox) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #808 +/- ##
=======================================
Coverage 98.30% 98.30%
=======================================
Files 93 93
Lines 2481 2481
Branches 462 461 -1
=======================================
Hits 2439 2439
Misses 42 42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
cecilia-donnelly
approved these changes
Jul 23, 2026
cecilia-donnelly
left a comment
cecilia-donnelly
left a comment
Member
There was a problem hiding this comment.
This is simultaneously very big and very limited, so I did the random sampling approach to my review. Tests are passing so I believe them that all is well!
ESM, rather than CommonJS, seems to be the module system of the future. We have some dependencies that we can't update without adopting ESM. So, this commit updates this project to use ESM instead of CommonJS.
liam-lloyd
force-pushed
the
per-10567_migrate_to_esm_modules
branch
from
July 23, 2026 21:21
c3c1e35 to
a7920ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ESM, rather than CommonJS, seems to be the module system of the future. We have some dependencies that we can't update without adopting ESM. So, this commit updates this project to use ESM instead of CommonJS.