Skip to content

[PER-10476] [5] Replace navigateMin with getWithChildren in folder picker#1092

Draft
aasandei-vsp wants to merge 1 commit into
PER-10476-replace-navigate-lean-v4from
PER-10476-replace-navigate-min-v5
Draft

[PER-10476] [5] Replace navigateMin with getWithChildren in folder picker#1092
aasandei-vsp wants to merge 1 commit into
PER-10476-replace-navigate-lean-v4from
PER-10476-replace-navigate-min-v5

Conversation

@aasandei-vsp

@aasandei-vsp aasandei-vsp commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Migrate the folder picker off /folder/navigateMin, its last consumer, and remove FolderRepo.navigate. The root.root folder stays on getRoot since Stela does not serve the virtual root.

Issue: PER-10476

Should not be merged before #1091

Manual test cases — Replace navigateMin with getWithChildren

Setup: log in on an archive with nested folders and at least one record. The folder picker opens from an item's Move, Copy, and Choose-file actions.
EXPECTED: the folder picker now loads folders through the Stela getWithChildren endpoint, except the top-level root which still loads through getRoot.


Move dialog

  1. Select an item and choose Move.
    • EXPECTED: The picker opens at the root, listing My Files and Public (not Apps or Vault), and the header shows the root folder name.
  2. Click into My Files, then into a subfolder.
    • EXPECTED: Each folder's subfolders load and the header name updates.
  3. Press Back repeatedly up to the top.
    • EXPECTED: The root reloads with My Files and Public — no blank or errored panel.
  4. Select a destination folder and confirm the Move.
    • EXPECTED: The item moves to the chosen folder and the dialog closes.

Copy dialog

  1. Select an item and choose Copy.
    • EXPECTED: The picker opens at the root with the same folders as above.
  2. Navigate into a folder, select it, and confirm the Copy.
    • EXPECTED: The item is copied to the chosen folder and the dialog closes.

Choose-file dialog

  1. Open the record chooser (Choose file).
    • EXPECTED: Both folders and records are listed (records are not stripped).
  2. Navigate into a folder and select a record.
    • EXPECTED: The record can be selected and confirmed.

Filtered move

  1. Move a folder into the tree.
    • EXPECTED: The folder being moved does not appear as a destination option.

Error handling

  1. With the picker open, go offline (DevTools > Network > Offline) and navigate into a folder.
    • EXPECTED: An error toast appears — no blank panel and no uncaught error in the console.

Migrate the folder picker off /folder/navigateMin, its last consumer,
and remove FolderRepo.navigate. The root.root folder stays on getRoot
since Stela does not serve the virtual root.

Issue: PER-10476
@aasandei-vsp aasandei-vsp self-assigned this Jul 20, 2026
@codecov

codecov Bot commented Jul 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 52.39%. Comparing base (a5815a0) to head (86c7a96).

Files with missing lines Patch % Lines
...omponents/folder-picker/folder-picker.component.ts 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                          Coverage Diff                           @@
##           PER-10476-replace-navigate-lean-v4    #1092      +/-   ##
======================================================================
+ Coverage                               52.23%   52.39%   +0.15%     
======================================================================
  Files                                     355      355              
  Lines                                   12131    12131              
  Branches                                 2191     2193       +2     
======================================================================
+ Hits                                     6337     6356      +19     
+ Misses                                   5566     5542      -24     
- Partials                                  228      233       +5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aasandei-vsp
aasandei-vsp marked this pull request as draft July 20, 2026 10:45
@aasandei-vsp aasandei-vsp changed the title [PER-10476] Replace navigateMin with getWithChildren in folder picker [PER-10476] [5] Replace navigateMin with getWithChildren in folder picker Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant