[PER-10667] Align public gallery date with detail view#1099
Open
aasandei-vsp wants to merge 1 commit into
Open
[PER-10667] Align public gallery date with detail view#1099aasandei-vsp wants to merge 1 commit into
aasandei-vsp wants to merge 1 commit into
Conversation
The public gallery card rendered its date from displayDT (mapped from the API's displayDate), while the detail sidebar reads displayTime || displayDT. For items where those fields diverge, the gallery showed a different date than the detail panel. Base the public-archive date on the existing startDisplayTime getter (displayTime with EDTF interval-start handling, falling back to displayDT) so the gallery matches the sidebar's field preference. Add spec coverage for the displayTime, displayDT-fallback, and EDTF-interval cases. Issue: PER-10667
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1099 +/- ##
==========================================
+ Coverage 52.15% 52.23% +0.08%
==========================================
Files 354 354
Lines 12090 12090
Branches 2186 2186
==========================================
+ Hits 6305 6315 +10
+ Misses 5560 5549 -11
- Partials 225 226 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The public gallery card rendered its date from displayDT (mapped from the API's displayDate), while the detail sidebar reads displayTime || displayDT. For items where those fields diverge, the gallery showed a different date than the detail panel.
Base the public-archive date on the existing startDisplayTime getter (displayTime with EDTF interval-start handling, falling back to displayDT) so the gallery matches the sidebar's field preference. Add spec coverage for the displayTime, displayDT-fallback, and EDTF-interval cases.
Issue: PER-10667
The dates I have found as being inconsistent with the rest of the app was in the gallery, so I have changed it to displayTime/displayDT:

The dates in the public folder behave as expected, like in private or shared.
Also, we are not actually supporting a friendly timezone as of now, but we will once the EDTF date will be released.