Conversation
📝 WalkthroughWalkthroughDocumentation update clarifying how the Permify Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
docs/getting-started/modeling.mdx (1)
275-297: Consider adding one concrete tuple-level example for the cross-org vs same-org distinction.The explanation is good; a 2–3 tuple mini-example here would make the “member in org A + admin in org B” vs “both on same org” contrast instantly obvious to readers.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docs/getting-started/modeling.mdx` around lines 275 - 297, Add a short 2–3 tuple example demonstrating the cross-org vs same-org difference using the existing entities/relations (entity user, organization with relations member and admin, repository with relation org and permission delete). Show one set of tuples where user is member of organization A and admin of organization B and indicate repository.delete is NOT granted, and a second set where the user is both member and admin on the same organization and indicate repository.delete IS granted; reference the permission names (organization.delete and repository.delete) and the relations (organization.member, organization.admin, repository.org) so readers can immediately see the different outcomes.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@docs/getting-started/modeling.mdx`:
- Around line 275-297: Add a short 2–3 tuple example demonstrating the cross-org
vs same-org difference using the existing entities/relations (entity user,
organization with relations member and admin, repository with relation org and
permission delete). Show one set of tuples where user is member of organization
A and admin of organization B and indicate repository.delete is NOT granted, and
a second set where the user is both member and admin on the same organization
and indicate repository.delete IS granted; reference the permission names
(organization.delete and repository.delete) and the relations
(organization.member, organization.admin, repository.org) so readers can
immediately see the different outcomes.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 14fc25af-1231-485c-918c-4a5c65b53f5e
📒 Files selected for processing (1)
docs/getting-started/modeling.mdx
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2837 +/- ##
==========================================
+ Coverage 82.58% 82.59% +0.02%
==========================================
Files 74 74
Lines 8297 8297
==========================================
+ Hits 6851 6852 +1
+ Misses 910 909 -1
Partials 536 536 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary by CodeRabbit
Release Notes
andoperator behavior in permission modeling documentation with improved explanations of how it intersects user sets across organizations