fix: sdk genarator workflow-dispatch action version#2845
Conversation
📝 WalkthroughWalkthroughUpdated the GitHub Action reference in the SDK generator workflow, reverting the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/sdk-generator.yml (1)
6-6:⚠️ Potential issue | 🔴 CriticalCritical YAML syntax error: incorrect indentation of
workflow_dispatch.The
workflow_dispatch:trigger is incorrectly nested underrelease:when it should be at the same indentation level asrelease:. This syntax error will prevent the workflow from being triggered manually and may cause workflow validation to fail.🐛 Proposed fix for YAML syntax
on: release: types: [published] - workflow_dispatch: + workflow_dispatch:🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/sdk-generator.yml at line 6, The YAML places workflow_dispatch under the release key, causing invalid workflow syntax; move workflow_dispatch out to be a top-level trigger entry at the same indentation level as release so that the workflow includes both release: and workflow_dispatch: as parallel keys (adjust indentation around the existing release block and ensure workflow_dispatch sits aligned with release).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In @.github/workflows/sdk-generator.yml:
- Line 6: The YAML places workflow_dispatch under the release key, causing
invalid workflow syntax; move workflow_dispatch out to be a top-level trigger
entry at the same indentation level as release so that the workflow includes
both release: and workflow_dispatch: as parallel keys (adjust indentation around
the existing release block and ensure workflow_dispatch sits aligned with
release).
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 2aa24e94-dddd-4da4-baae-dad6c689e5e6
📒 Files selected for processing (1)
.github/workflows/sdk-generator.yml
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2845 +/- ##
==========================================
+ Coverage 82.58% 82.59% +0.02%
==========================================
Files 74 74
Lines 8297 8297
==========================================
+ Hits 6851 6852 +1
+ Misses 910 909 -1
Partials 536 536 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary by CodeRabbit