Skip to content

fix(test): register two dark GC string tests in the repsel corpus #8467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
proggeramlug merged 1 commit into from
Aug 20, 2026
Merged

fix(test): register two dark GC string tests in the repsel corpus #8467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/8461-register-dark-gc-tests.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Register `test_gap_gc_string_copy_source_rooting` and `test_gap_gc_string_repeat_reentrant_count` in `test-parity/gc_repsel_corpus.txt`. #8439 and #8443 added them to `test-files/` without registering them, so `scripts/gc_repsel_matrix.sh` never executed either — a GC regression test that never runs is not a gate. `check_test_registration` was red on `main`.
8 changes: 8 additions & 0 deletions test-parity/gc_repsel_corpus.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -816,3 +816,11 @@ test_gap_gc_http2_pending_event_callback_rooting
# `Object.getPrototypeOf(undefined)` throws. Pre-fix `bad > 0` under seeded
# GC; post-fix `bad 0`. Clean under `PERRY_GEN_GC=0`.
test_gap_gc_interp_global_this_rooting

# #8439: `js_string_copy` borrowed its source's bytes across an allocation that
# can trigger a moving minor. Registered so gc-stress / gc-moving-witnesses
# actually execute it instead of leaving it dark on disk.
test_gap_gc_string_copy_source_rooting
# #8443: `String.prototype.repeat` held its receiver unrooted across a
# re-entrant count coercion. Same reason.
test_gap_gc_string_repeat_reentrant_count
Loading