Skip to content

chore(changelog): give the three 0000 fragments their PR numbers - #8973

Merged
proggeramlug merged 1 commit into
mainfrom
chore/changelog-pr-keys
Aug 28, 2026
Merged

chore(changelog): give the three 0000 fragments their PR numbers#8973
proggeramlug merged 1 commit into
mainfrom
chore/changelog-pr-keys

Conversation

@proggeramlug

Copy link
Copy Markdown
Contributor

changelog.d/README.md keys fragment filenames on the PR number precisely so in-flight PRs cannot collide. Three landed as 0000-, which collides with every other placeholder — and the collision is silent, since fragments are only folded into release notes at tag time.

Traced each to the commit that introduced it:

fragment commit PR
0000-inline-array-pop-tier.md ae21f190b #8944
0000-inline-method-shape-probe.md cae1b95c3 #8947
0000-node-version-26.5.1.md 187941ff8 #8291

Pure renames, no content changes. Zero 0000- fragments remain.

I merged two of these three myself (#8944, #8947) without noticing the placeholder — worth a mention since the next one to land with 0000- would have silently overwritten nothing but been equally hard to attribute at release time.

Fragment filenames are PR-keyed (changelog.d/README.md) precisely so in-flight
PRs cannot collide — and `0000` collides with every other placeholder. Traced
each to the commit that introduced it:

  0000-inline-array-pop-tier.md      -> 8944 (ae21f19)
  0000-inline-method-shape-probe.md  -> 8947 (cae1b95)
  0000-node-version-26.5.1.md        -> 8291 (187941f)
@coderabbitai

coderabbitai Bot commented Aug 28, 2026

Copy link
Copy Markdown

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

💤 Files selected but had no reviewable changes (3)
  • changelog.d/8291-node-version-26.5.1.md
  • changelog.d/8944-inline-array-pop-tier.md
  • changelog.d/8947-inline-method-shape-probe.md
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 0d9326d9-477d-4705-b0d9-74e5ce9b635a

📥 Commits

Reviewing files that changed from the base of the PR and between 00f4671 and 701fb6f.

📒 Files selected for processing (3)
  • changelog.d/8291-node-version-26.5.1.md
  • changelog.d/8944-inline-array-pop-tier.md
  • changelog.d/8947-inline-method-shape-probe.md

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@proggeramlug
proggeramlug merged commit 062b3f7 into main Aug 28, 2026
20 checks passed
@proggeramlug
proggeramlug deleted the chore/changelog-pr-keys branch August 28, 2026 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant