Batch DB commits during score/tailor/cover instead of one commit at the end - #100
Open
msohailse wants to merge 1 commit into
Open
Batch DB commits during score/tailor/cover instead of one commit at the end#100msohailse wants to merge 1 commit into
msohailse wants to merge 1 commit into
Conversation
score/tailor/cover-letter stages each held every result in memory and wrote them to the DB in a single commit after the entire job list finished. If the run got interrupted, crashed, or hit an external error partway through (rate limit, network drop, killed process), everything already completed that run was lost -- nothing had been persisted yet. All three stages now flush to the DB every 5 jobs (and on the final job), so an interruption only loses the batch in progress, not the whole run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
score, tailor, and cover-letter stages each collected every result in memory and only wrote to the DB in a single commit after the whole job list finished. If the run got interrupted partway through -- rate limit, network drop, killed process, crash -- nothing already completed that run had been persisted, so it was all lost.
main.Test plan
ruff check/ruff format --checkon all three files -- identical finding count to unmodifiedmain(18 pre-existing, 0 new)🤖 Generated with Claude Code