fix: use semantic versioning for version comparisons in check-images-internal.ts#3921
fix: use semantic versioning for version comparisons in check-images-internal.ts#3921
Conversation
Bump previous/current release to v8.5.3 and v8.5.4 Make collect-info-for-release-issue.sh executable
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
Hi @Copilot. Thanks for your PR. I'm waiting for a PingCAP-QE member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Co-authored-by: wuhuizuo <2574558+wuhuizuo@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
String-based version comparison is unreliable for semantic versions. For example,
"v8.5.10" <= "v8.5.3"incorrectly returnstruebecause"1" < "3"lexicographically.Changes
@std/semver(already used elsewhere in this repo)normalizeVersion()to stripvprefix and-enterprisesuffixversionGreaterOrEqual()andversionLessThanOrEqual()helper functionsExample
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.