Sound effects system Part 1: Assets, Stereo sound#3281
Open
RanPix wants to merge 41 commits into
Open
Conversation
Contributor
Author
|
also for now you can tp to 0 0 0 to hear a testing sound thats constantly playing for stereo |
Contributor
|
CI failed but I also don't understand if this is supposed to be reviewed? |
Contributor
Author
|
i think this is ready for review, just a few things to be done before merging:
|
Collaborator
2026-07-15.10-16-13.mp4Still broken on my side |
Collaborator
|
Could you record how it's supposed to sound on Linux? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
requires #3367
this is mostly intended to be a base for other people to maybe continue on this
has a bit of renaming and test code, i still have to figure out what we will need
the questions i have for now:
and i also would want to discuss how the ideal api for that would look like, and maybe what tools do we give to the artists
todo:
doppler effect- separate prsimd sound mixing?- separate pr probablyplaying sounds limit- separate prvolume control based on how many of the same sounds are playing at the same time?- separate pr