Skip to content

Sound effects system Part 1: Assets, Stereo sound#3281

Open
RanPix wants to merge 41 commits into
PixelGuys:masterfrom
RanPix:esefeks
Open

Sound effects system Part 1: Assets, Stereo sound#3281
RanPix wants to merge 41 commits into
PixelGuys:masterfrom
RanPix:esefeks

Conversation

@RanPix

@RanPix RanPix commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

requires #3367

this is mostly intended to be a base for other people to maybe continue on this

has a bit of renaming and test code, i still have to figure out what we will need

the questions i have for now:

  • do we want to be able to change the position of sounds? that would require creating some sort of audio soruce with a handle to a current playing sound which could allow for some cool things like a moving breathing of some scary monster
  • how would/should we integrate the sound system with music later?
  • in future, do we want to have dynamically changable special effects like pitch, reverb or distortion? so that for example when you break the same block all the time it has some pitch variation to make it less repetative

and i also would want to discuss how the ideal api for that would look like, and maybe what tools do we give to the artists

todo:

  • doppler effect - separate pr
  • simd sound mixing? - separate pr probably
  • playing sounds limit - separate pr
  • volume control based on how many of the same sounds are playing at the same time? - separate pr
  • find other optimizations
  • sound zon files should be able to specify the sound file they are using so we can reuse sounds in some cases? (could also be a separate pr if we need that)
  • dont process sounds that are too far / too silent

@RanPix

RanPix commented Jun 24, 2026

Copy link
Copy Markdown
Contributor Author

also for now you can tp to 0 0 0 to hear a testing sound thats constantly playing for stereo

@Wunka

Wunka commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

CI failed but I also don't understand if this is supposed to be reviewed?

@Wunka Wunka moved this to WIP/not ready for review in PRs to review Jul 5, 2026
@RanPix RanPix marked this pull request as draft July 5, 2026 15:57
@RanPix RanPix marked this pull request as ready for review July 15, 2026 13:10
@RanPix

RanPix commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

i think this is ready for review, just a few things to be done before merging:

  • remove testing sound/s
  • fix windows sounds going insane

@ikabod-kee

Copy link
Copy Markdown
Collaborator
2026-07-15.10-16-13.mp4

Still broken on my side

@ikabod-kee

Copy link
Copy Markdown
Collaborator

Could you record how it's supposed to sound on Linux?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: WIP/not ready for review

Development

Successfully merging this pull request may close these issues.

3 participants