Shader includes#3374
Merged
IntegratedQuantum merged 3 commits intoJul 17, 2026
Merged
Conversation
Member
Author
|
Ok, I managed to get the CI working, so that only leaves the poor usability in VSCode, but to be honest it's not much worse than status quo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is done in our code since OpenGL's driver support is rather lacking.
Also I found the required extension naming
#extension GL_ARB_shading_language_include : requirerather annoying which comes which comes with other parsers, so I omitted it here. Furthermore my VSCode extension for glsl does not properly support includes whether they have it or not.Here I implemented includes for chunk data as an example.
fixes #105
required for #3335