Skip to content

Address PR #7 review thread: lifecycle docs + startup logging behavior#8

Merged
Pmaster-dev merged 3 commits into
developfrom
copilot/fix-code-for-review-comments
Jul 6, 2026
Merged

Address PR #7 review thread: lifecycle docs + startup logging behavior#8
Pmaster-dev merged 3 commits into
developfrom
copilot/fix-code-for-review-comments

Conversation

Copilot AI commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

This update resolves all actionable comments from review thread pullrequestreview-4630653075, with scope limited to the requested thread. Changes align lifecycle documentation with actual engine behavior and remove import-time INFO log noise introduced by default engine startup.

  • Lifecycle contract docs aligned with runtime behavior

    • EngineNotStartedError docstring now explicitly covers both trigger() and trigger_type().
    • AutomationEngine.stop() docstring now states that stop deregisters components, so restart requires re-registration.
  • Startup logging adjusted for library ergonomics

    • AutomationEngine.start() startup message moved from INFO to DEBUG to avoid INFO output during module import (default_engine.start() side effect).
  • Regression coverage for log-level expectation

    • Added a focused test asserting startup emits the expected DEBUG log record.
# before
logger.info("AutomationEngine started")

# after
logger.debug("AutomationEngine started")

Copilot AI changed the title [WIP] Fix code based on review comments Address PR #7 review thread: lifecycle docs + startup logging behavior Jul 5, 2026
Copilot AI requested a review from Pmaster-dev July 5, 2026 16:01
@Pmaster-dev Pmaster-dev marked this pull request as ready for review July 6, 2026 02:07
@Pmaster-dev Pmaster-dev merged commit 64652b8 into develop Jul 6, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants