Skip to content

Refactor sprites build - #1691

Merged
Naramsim merged 2 commits into
PokeAPI:masterfrom
FallenDeity:refactor-sprites-build
Oct 7, 2026
Merged

Naramsim merged 2 commits into
PokeAPI:masterfrom
FallenDeity:refactor-sprites-build

Conversation

@FallenDeity

Copy link
Copy Markdown
Contributor

Change description

Cloning all of the sprites submodule just to build this repo is redundant since all we do is just check paths the actual sprite data is never used, hence this pr now uses the manifest published whenever there is a change in sprites repo to build the sprites introduced in pr PokeAPI/sprites#289

a manifest is published both as raw json and gzipped json in compressed format for example view here https://pokeapi.github.io/sprites/manifest.json its published both via releases and github pages which is used as a catalogue to build all the data for sprites in build.py

AI coding assistance disclosure

None

Contributor check list

  • I have written a description of the contribution and explained its motivation.
  • I have written tests for my code changes (if applicable).
  • I have read and understood the AI Assisted Contribution guidelines.
  • I will own this change in production, and I am prepared to fix any bugs caused by my code change.

@Naramsim

Naramsim commented Oct 7, 2026

Copy link
Copy Markdown
Member

Thanks for the work! This will help many people :)

I'm merging this now since I need it for the GQL environment (the space on the machine is zero). The only thing that I don't particulary like is the additions of all the dashes in the markdown tables. We can remove the in future

@Naramsim
Naramsim merged commit dd499a3 into PokeAPI:master Oct 7, 2026
22 checks passed
@pokeapi-machine-user

Copy link
Copy Markdown

A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and the entire API will be ready to review.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

@pokeapi-machine-user

Copy link
Copy Markdown

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

The Pull Request can be seen deployed in our staging environment when CircleCI deploy will be finished (check the start time of the last build).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants