Add URL health view and expose health in data source sync/API#598
Merged
Add URL health view and expose health in data source sync/API#598
Conversation
2 tasks
josh-chamberlain
approved these changes
Mar 9, 2026
Contributor
josh-chamberlain
left a comment
josh-chamberlain
left a comment
There was a problem hiding this comment.
very nice! getting this back on API requests is wonderful...seeing it in the UI would be neat: Police-Data-Accessibility-Project/pdap.io#421
Resolved conflict in process.py: kept url_health field from this branch alongside access_types from dev. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 15086721 | Triggered | Generic Password | 38333d2 | .github/workflows/benchmark.yml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Resolved conflict in process.py: kept url_health field from this branch. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The merge from dev introduced a separate migration head (f831e447b1cb) that wasn't connected to the url_health migration (7a6c2e1b9d44), causing "Multiple head revisions" errors in CI. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#341
Summary
url_health_view(SQL view + ORM model + enum) to separate URL health from labeling statusurl_status+ archive URL)url_healthon data source GET responsesTesting
docker compose up -d(fromlocal_database/)POSTGRES_USER=test_source_collector_user POSTGRES_PASSWORD=HanviliciousHamiltonHilltops POSTGRES_DB=source_collector_test_db POSTGRES_HOST=127.0.0.1 POSTGRES_PORT=5432 UV_CACHE_DIR=/tmp/uv-cache uv run pytest tests/automated/integration/readonly/api/data_sources/test_get.py tests/automated/integration/tasks/scheduled/impl/sync_to_ds/data_source/test_add.py tests/automated/integration/tasks/scheduled/impl/sync_to_ds/data_source/update/test_update_url.py -q3 passed