Skip to content

Preserve nullable budget-window output fields#487

Merged
anth-volk merged 1 commit into
mainfrom
fix-budget-window-result-client-parsing
May 12, 2026
Merged

Preserve nullable budget-window output fields#487
anth-volk merged 1 commit into
mainfrom
fix-budget-window-result-client-parsing

Conversation

@anth-volk
Copy link
Copy Markdown
Contributor

Summary

  • Return completed budget-window status responses through JSONResponse using the full serialized payload so nullable single-year output fields remain present as null.
  • Add a gateway regression assertion that completed budget-window JSON retains nullable output keys required by the generated client parser.

Verification

  • uv run pytest tests/gateway/test_endpoints.py::TestBudgetWindowBatchEndpoints::test__given_batch_state__then_poll_returns_completed_response -q
  • uv run ruff check src/modal/gateway/responses.py tests/gateway/test_endpoints.py
  • Generated-client parse reproduction: missing nullable keys parsed as raw dict; present null keys parsed as BudgetWindowResult.

@anth-volk anth-volk merged commit 824fc03 into main May 12, 2026
4 checks passed
@anth-volk anth-volk deleted the fix-budget-window-result-client-parsing branch May 12, 2026 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant