Skip to content

Use Next.js icon file convention so favicon respects multi-zone basePath #856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SakshiKekre wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Use Next.js icon file convention so favicon respects multi-zone basePath #856

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f3c8260
Respect multizone base path for icons and assets
SakshiKekre Apr 24, 2026
43e59a0
Use Next.js icon file convention for favicon
SakshiKekre May 3, 2026
e92b400
Add changelog fragment
SakshiKekre May 3, 2026
f1b06e4
Revert env-driven basePath; keep literal /us/taxsim per Next.js docs
SakshiKekre May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/fix-multizone-icon-basepath.changed.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Make TAXSIM base path configurable via NEXT_PUBLIC_BASE_PATH and use Next.js' icon file convention so the favicon resolves under the multizone basePath.
0 dashboard/public/policyengine.png → dashboard/src/app/icon.png
View file
Open in desktop
File renamed without changes
4 changes: 0 additions & 4 deletions dashboard/src/app/layout.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,6 @@ export const metadata = {
description:
'The next chapter of TAXSIM. Open-source, drop-in compatible tax calculator powered by PolicyEngine.',
},
icons: {
icon: '/policyengine.png',
apple: '/policyengine.png',
},
alternates: {
canonical: 'https://policyengine.org/us/taxsim',
},
Expand Down
Loading