Tighten /diagnose-issue: input parity in Step 6, verify reporter's claims in Step 1#897
Merged
Merged
Conversation
…Simulation Lesson from re-examining taxsim #882: forgetting to pass tax_unit_childcare_expenses in a direct Simulation situation zeroed the federal CDCC, which shifted tax_liability_if_not_itemizing by ~$300 and made it look like Microsim and Simulation produced different answers. They actually agreed — I was comparing apples to oranges because the inputs weren't identical. Step 6 now mandates a TAXSIM-to-PE variable cross-walk before running a direct Simulation, with a table of the easy-to-miss mappings (childcare → tax_unit_childcare_expenses, proptax → real_estate_taxes, mortgage → deductible_mortgage_interest, rentpaid → rent). Debugging checklist updated to match. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
… against output.txt If the reporter cites a specific PE value, confirm it appears in the bundle's output.txt before building a diagnosis around it. Reporters sometimes paste values from a different case; without this check you can construct a wrong narrative around a wrong number. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two skill refinements based on running the workflow on taxsim issues #882 and #878:
Step 6 — input parity is critical (commit
37dbc1f). When dropping into a directSimulationto inspect intermediates, every non-zero TAXSIM input fromtxpydata.csvmust be mapped to its PE-US variable. Forgetting one (especiallytax_unit_childcare_expensesfromchildcare, which lives on the tax_unit not the person) produces different intermediates than the emulator and you mis-attribute a real bug to a "framework difference." Added a cross-walk table for the easy-to-miss mappings, plus a "verify input parity by running the emulator on the same row" instruction.Step 1 — treat the reporter's claim as a hypothesis (commit
c7688dd). If the reporter cites a specific PE value, confirm it appears in the bundle'soutput.txtbefore building a diagnosis around it. Reporters sometimes paste values from a different case; without this check you can construct a wrong narrative around a wrong number.Test plan
🤖 Generated with Claude Code