Reenable download from cache but not async#143
Merged
Conversation
mikesmit
force-pushed
the
350_use_caching_no_async
branch
2 times, most recently
from
253e1ea to
b6ac808
Compare
anth-volk
reviewed
May 19, 2025
| @@ -0,0 +1,5 @@ | |||
| ======= | |||
Contributor
There was a problem hiding this comment.
issue, minor, blocking: Please remove this line
anth-volk
reviewed
May 19, 2025
Related to PolicyEngine/issues#350 this change re-implements the download_file_from_gcs function to use CachingGoogleStorageClient and removes the async stuff from the client to avoid issues with the existing event loop. Files should now be cached locally on a per-process basis and only updated on disk when the remote version crc changes.
mikesmit
force-pushed
the
350_use_caching_no_async
branch
from
b6ac808 to
646cfe0
Compare
anth-volk
approved these changes
May 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to PolicyEngine/issues#350
this change re-implements the download_file_from_gcs function to use CachingGoogleStorageClient and removes the async stuff from the client to avoid issues with the existing event loop.
Files should now be cached locally on a per-process basis and only updated on disk when the remote version crc changes.