Always check for a new data file version even if one has been downloa…#146
Merged
Conversation
…ded. Related to PolicyEngine/issues#350 The existing code is pretty inconsistent in terms of how/when it decides to try to download a data file and we haven't clearly defined the intended behavior. We are prioritizing the simulation API use case in which case we always want to use the most recent version of the data file for a simulation. This change means that if the code specifies a remote data file (either by explicitly giving a url or by defaulting to a country dataset) we will always check for a new version when creating a Simulation object even if we have a local copy.
mikesmit
force-pushed
the
350_always_check_for_new_versions
branch
from
7c052bc to
f78f538
Compare
anth-volk
approved these changes
May 22, 2025
Contributor
anth-volk
left a comment
anth-volk
left a comment
There was a problem hiding this comment.
LGTM! Would appreciate holding off on merging until May 23 while I run some regression tests locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ded.
Related to PolicyEngine/issues#350
The existing code is pretty inconsistent in terms of how/when it decides to try to download a data file and we haven't clearly defined the intended behavior.
We are prioritizing the simulation API use case in which case we always want to use the most recent version of the data file for a simulation.
This change means that if the code specifies a remote data file (either by explicitly giving a url or by defaulting to a country dataset) we will always check for a new version when creating a Simulation object even if we have a local copy.