Repository navigation
chore: drop --min=100 from test:unit, it was ignored without --coverage - #580
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
composer test:unitranpest --colors=always --min=100. Pest only applies--mintogether with--coverage, which the script does not pass: the CI step has always been green while the line coverage is 53%. The flag enforced nothing and contradicted what the README, CONTRIBUTING and CLAUDE.md say since #579 (type coverage at 98% is enforced, line coverage is held by the Harness ratchet).The script is now
pest --colors=always. Behaviour is unchanged.