Add POLY_1271 deposit wallet support#85
Open
sharananurag998 wants to merge 3 commits into
Open
Conversation
sharananurag998
marked this pull request as ready for review
July 18, 2026 06:57
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8c044fe. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What changed
poly-1271as a supported CLI signature type--funder,POLYMARKET_FUNDER, and optional config-file funder supportWhy
The V2 Rust SDK already supports
SignatureType::Poly1271, but the CLI only mapped EOA, proxy, and Gnosis Safe modes and had no way to supply the required deposit-wallet funder. Email and social-login accounts backed by Polymarket deposit wallets therefore authenticated against the wrong wallet or could not see their collateral.Impact
Users with a Polymarket deposit wallet can authenticate to CLOB V2 and use trading and account commands with the correct funding address. Existing EOA, proxy, and Gnosis Safe configurations remain backward compatible.
Validation
cargo check --all-targetscargo test --all-targets(138 tests passed)cargo clippy --all-targets -- -D warningsPOLY_1271deposit wallet; no order was created or postedNote
Medium Risk
Changes CLOB authentication and order signing for a new wallet mode; validation reduces wrong-wallet auth, but trading behavior depends on the upgraded SDK.
Overview
Adds
poly-1271so email/social Polymarket accounts can use the CLI against their deposit wallet, not just EOA/proxy/Gnosis Safe modes. Users must supply the funding address via--funder,POLYMARKET_FUNDER, or configfunder; supplying a funder with any other signature type is rejected so CLOB auth cannot target the wrong wallet.CLOB authentication and trading paths pass the funder into
polymarket_client_sdk_v20.7.0 (bumped from 0.5.1 for deposit-wallet maker/signer and ERC-7739 signatures). Wallet create/import/show persist and display the funder;approve checkresolves the owner from the funder in poly-1271 mode.On-chain mutations (
approve set, CTF split/merge/redeem) are blocked for poly-1271 with a clear error; signature type parsing is stricter (unknown types error instead of defaulting to EOA). README and integration tests cover setup and pre-network validation.Reviewed by Cursor Bugbot for commit 72d8723. Bugbot is set up for automated code reviews on this repo. Configure here.