chore: default selector labels to differentiate dataservice and gateway#186
Open
sk-portkey wants to merge 1 commit intomainfrom
Open
chore: default selector labels to differentiate dataservice and gateway#186sk-portkey wants to merge 1 commit intomainfrom
sk-portkey wants to merge 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Helm chart defaults to ensure the optional dataservice resources can be distinguished from the gateway resources via Kubernetes selector labels.
Changes:
- Sets a non-empty default for
dataservice.deployment.selectorLabels.app.kubernetes.io/namein chart values.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sk-portkey
force-pushed
the
chore/default_selector_labels
branch
from
00010b3 to
8a420f8
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Helm chart defaults so the Data Service resources can be selected independently from the Gateway by giving Data Service a distinct default app.kubernetes.io/name selector label.
Changes:
- Set a non-empty default for
dataservice.deployment.selectorLabels.app.kubernetes.io/nametodataservice.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.