fix: Remove snapshot APIs that deadlock libuv thread pool#1338
Merged
charlesvien merged 2 commits intomainfrom Mar 30, 2026
Merged
fix: Remove snapshot APIs that deadlock libuv thread pool#1338charlesvien merged 2 commits intomainfrom
charlesvien merged 2 commits intomainfrom
Conversation
This was referenced Mar 26, 2026
charlesvien
changed the title
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
charlesvien
force-pushed
the
03-26-file-watcher-crashes
branch
from
7f8af48 to
a539262
Compare
charlesvien
force-pushed
the
03-26-detect_non-standard_default_branch_names
branch
from
b99d30b to
a01c096
Compare
charlesvien
force-pushed
the
03-26-file-watcher-crashes
branch
from
a539262 to
b4abfe4
Compare
charlesvien
force-pushed
the
03-26-detect_non-standard_default_branch_names
branch
from
a01c096 to
32623d4
Compare
Draft
charlesvien
force-pushed
the
03-26-detect_non-standard_default_branch_names
branch
from
32623d4 to
e9fe4ae
Compare
charlesvien
force-pushed
the
03-26-file-watcher-crashes
branch
from
b4abfe4 to
8feb992
Compare
k11kirky
approved these changes
Mar 30, 2026
charlesvien
force-pushed
the
03-26-file-watcher-crashes
branch
from
8feb992 to
684ed91
Compare
charlesvien
force-pushed
the
03-26-detect_non-standard_default_branch_names
branch
2 times, most recently
from
47d5494 to
e5d8a2b
Compare
charlesvien
force-pushed
the
03-26-file-watcher-crashes
branch
from
684ed91 to
ee4142b
Compare
Member
Author
Merge activity
|
charlesvien
changed the base branch from
03-26-detect_non-standard_default_branch_names
to
graphite-base/1338
charlesvien
force-pushed
the
03-26-file-watcher-crashes
branch
from
ee4142b to
28c60f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
@parcel/watcher's getEventsSince() and writeSnapshot() block libuv worker
threads indefinitely via a native mutex deadlock in FSEventsBackend, saturating
the default 4-thread pool and preventing clean shutdown.
Changes
How did you test this?
Manually