feat(code): replace in-chat diffs with pierre/diffs#1414
Open
adboio wants to merge 1 commit into03-31-feat_code_new_diff_review_panelfrom
Open
feat(code): replace in-chat diffs with pierre/diffs#1414adboio wants to merge 1 commit into03-31-feat_code_new_diff_review_panelfrom
adboio wants to merge 1 commit into03-31-feat_code_new_diff_review_panelfrom
Conversation
This was referenced Apr 1, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 1, 2026
This was referenced Apr 1, 2026
82153f2 to
1ce1ac4
Compare
2b4b7a1 to
873c4d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem
as part of #1410, i replaced codemirror with
@pierre/diffsin the changed file diff viewsbut the in-chat diffs still use codemirror
Changes
for consistency mostly, replacing the in-chat diff view with the same thing, and some related cleanup
How did you test this?
manually