feat(code): add commit trailers for attribution#1431
Merged
Conversation
Contributor
Author
This was referenced Apr 1, 2026
This was referenced Apr 1, 2026
adboio
force-pushed
the
posthog-code/improve-code-review-workflow-and-diff-viewer
branch
2 times, most recently
from
d365a2d to
6254681
Compare
adboio
force-pushed
the
04-01-feat_code_add_commit_trailers_for_attribution
branch
from
eda1ca1 to
28fc5ee
Compare
charlesvien
approved these changes
Apr 2, 2026
adboio
force-pushed
the
04-01-feat_code_add_commit_trailers_for_attribution
branch
from
28fc5ee to
4bbd9d3
Compare
adboio
force-pushed
the
posthog-code/improve-code-review-workflow-and-diff-viewer
branch
from
6254681 to
9df7fb1
Compare
adboio
changed the base branch from
posthog-code/improve-code-review-workflow-and-diff-viewer
to
graphite-base/1431
adboio
force-pushed
the
04-01-feat_code_add_commit_trailers_for_attribution
branch
from
4bbd9d3 to
3dd25b5
Compare
adboio
force-pushed
the
graphite-base/1431
branch
from
9df7fb1 to
5857e2f
Compare
adboio
force-pushed
the
04-01-feat_code_add_commit_trailers_for_attribution
branch
from
3dd25b5 to
ccbbd0c
Compare
Contributor
Author
adboio
added a commit
that referenced
this pull request
Apr 3, 2026
## Problem we explicitly instruct the (cloud) agent to not include any attribution lines -- presumably to avoid the default claude code stuff however, this means there's also no attribution back to posthog code <!-- Who is this for and what problem does it solve? --> <!-- Closes #ISSUE_ID --> ## Changes - cloud: replaces the "no attribution" prompting with instructions to add commit trailers (see #1431 ) and PR body footers - local: adds new commit+PR attribution instructions, which hopefully will override whatever is injected by claude code <!-- What did you change and why? --> <!-- If there are frontend changes, include screenshots. --> ## How did you test this? i haven't yet 🙈 <!-- Describe what you tested -- manual steps, automated tests, or both. --> <!-- If you're an agent, only list tests you actually ran. -->
adboio
added a commit
that referenced
this pull request
Apr 3, 2026
## Problem #1431 adds commit trailers when committing via UI, #1432 adds trailers + PR body instructions for agent now we need to add PR body footer when creating a PR via UI <!-- Who is this for and what problem does it solve? --> <!-- Closes #ISSUE_ID --> ## Changes appends "created by posthog code" to PR body when creating from UI <!-- What did you change and why? --> <!-- If there are frontend changes, include screenshots. --> ## How did you test this? <!-- Describe what you tested -- manual steps, automated tests, or both. --> <!-- If you're an agent, only list tests you actually ran. --> PostHog/posthog#53123
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
we don't (yet) do a great job of attributing work done by posthog code back to posthog code.
one small step in that direction is adding commit trailers to all commits made in our UI
Changes
adds commit trailers to all commits from the UI, with a reference to posthog code and the task ID
How did you test this?
tested manually, sample
git log: