Skip to content

feat(cloud): negotiate idempotent steer delivery#3538

Open
tatoalo wants to merge 1 commit into
posthog-code/cloud-steering-agent-adaptersfrom
posthog-code/cloud-steering-agent-delivery
Open

feat(cloud): negotiate idempotent steer delivery#3538
tatoalo wants to merge 1 commit into
posthog-code/cloud-steering-agent-adaptersfrom
posthog-code/cloud-steering-agent-delivery

Conversation

@tatoalo

@tatoalo tatoalo commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Problem

Cloud steer delivery needs negotiated capability and idempotent retry behavior.

Changes

Adds protocol negotiation, in-flight delivery deduplication, and safe normal-turn fallback.

tatoalo commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown

React Doctor found no issues in the changed files. 🎉

Reviewed by React Doctor for commit a04d2b1.

@tatoalo tatoalo self-assigned this Jul 17, 2026
@tatoalo
tatoalo marked this pull request as ready for review July 17, 2026 14:48
@tatoalo
tatoalo force-pushed the posthog-code/cloud-steering-agent-adapters branch from bf461dd to 8bc8d62 Compare July 20, 2026 08:16
@tatoalo
tatoalo force-pushed the posthog-code/cloud-steering-agent-delivery branch from 7c71a62 to 5f639c8 Compare July 20, 2026 08:16
@posthog

posthog Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

👋 Visual changes detected for this PR.

Review and approve in PostHog Visual Review

If these changes are unexpected, they may be caused by a flaky test or a broken snapshot on master. Don't approve — rerun the job or wait for a fix.

@tatoalo
tatoalo force-pushed the posthog-code/cloud-steering-agent-adapters branch from 8bc8d62 to 49fc050 Compare July 20, 2026 14:45
@tatoalo
tatoalo force-pushed the posthog-code/cloud-steering-agent-delivery branch from 5f639c8 to 9192b57 Compare July 20, 2026 14:46
@tatoalo
tatoalo requested a review from a team July 20, 2026 14:51
@tatoalo tatoalo added the Stamphog This will request an autostamp by stamphog on small changes label Jul 20, 2026

@stamphog stamphog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a T1d-complex PR (741 lines, 7 files) with zero reviews, touching core agent protocol semantics: new concurrent delivery deduplication via inFlightMessageDeliveries, a counter-based owned-turn tracker for steer eligibility, and a behavioral policy change to sessionSupportsNativeSteer that enables cloud steering when explicitly negotiated. The code appears internally consistent and well-tested, but the concurrency state and protocol-level changes warrant at least one domain expert sign-off before auto-approval.

@stamphog stamphog Bot removed the Stamphog This will request an autostamp by stamphog on small changes label Jul 20, 2026
@tatoalo
tatoalo force-pushed the posthog-code/cloud-steering-agent-adapters branch from 49fc050 to eba3248 Compare July 20, 2026 17:53
@tatoalo
tatoalo force-pushed the posthog-code/cloud-steering-agent-delivery branch from 9192b57 to a04d2b1 Compare July 20, 2026 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants