-
Notifications
You must be signed in to change notification settings - Fork 36
feat: propagate personProperties and groups in feature flag events #383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -454,7 +454,16 @@ public open class PostHogStateless protected constructor( | |
| groupProperties, | ||
| )?.let { props["\$feature_flag_error"] = it } | ||
|
|
||
| captureStateless(PostHogEventName.FEATURE_FLAG_CALLED.event, distinctId, properties = props) | ||
| val userProps = personProperties | ||
| ?.filterValues { it != null } | ||
| ?.mapValues { it.value!! } | ||
| captureStateless( | ||
| PostHogEventName.FEATURE_FLAG_CALLED.event, | ||
| distinctId, | ||
| properties = props, | ||
| userProperties = userProps, | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Providing What's the behavior we're looking for by doing this?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. shouldn't it? for me if we change a property of the user with a feature flag, we should reflect it , shouldnt we?
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @dustinbyrne mind to follow up here? PR is stale for a while
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm open to hearing more about the case of changing a property with a feature flag. Currently, however, I don't believe this is the behavior in any of our other SDKs. The The additional propagation of |
||
| groups = groups, | ||
| ) | ||
| } | ||
| } | ||
| } | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.