Skip to content

add: getAllFeatureFlagDetails method#476

Open
MohitMandalia wants to merge 8 commits intoPostHog:mainfrom
MohitMandalia:get-all-featureflag-details
Open

add: getAllFeatureFlagDetails method#476
MohitMandalia wants to merge 8 commits intoPostHog:mainfrom
MohitMandalia:get-all-featureflag-details

Conversation

@MohitMandalia
Copy link
Copy Markdown
Contributor

@MohitMandalia MohitMandalia commented Apr 2, 2026

💡 Motivation and Context

Fixes: #449

💚 How did you test it?

Yes wrote unit tests

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

If releasing new changes

  • Ran pnpm changeset to generate a changeset file
  • Added the "release" label to the PR to indicate we're publishing new versions for the affected packages

@MohitMandalia MohitMandalia marked this pull request as ready for review April 6, 2026 02:50
@MohitMandalia MohitMandalia requested a review from a team as a code owner April 6, 2026 02:50
@MohitMandalia
Copy link
Copy Markdown
Contributor Author

I would prefer consistent types across all sdks but I see a method return FeatureFlagResult so used the same let me know if it needs a change.

@MohitMandalia MohitMandalia changed the title add: getAllFeatureFlagDetails method [WIP] add: getAllFeatureFlagDetails method Apr 6, 2026
Copy link
Copy Markdown
Contributor

@dustinbyrne dustinbyrne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together, @MohitMandalia. I've added some comments below!

@MohitMandalia MohitMandalia marked this pull request as draft April 7, 2026 09:20
@MohitMandalia MohitMandalia marked this pull request as ready for review April 7, 2026 09:29
@marandaneto
Copy link
Copy Markdown
Member

left 2 comments, also add a changeset entry https://github.com/PostHog/posthog-android/blob/main/RELEASING.md#creating-a-changeset

Copy link
Copy Markdown
Member

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments otherwise lgtm

@MohitMandalia
Copy link
Copy Markdown
Contributor Author

left 2 comments, also add a changeset entry https://github.com/PostHog/posthog-android/blob/main/RELEASING.md#creating-a-changeset

lmk if I generated it correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add getAllFeatureFlags method

3 participants