fix: move getDeviceId() after enabled=true and add android to changeset#488
Merged
fix: move getDeviceId() after enabled=true and add android to changeset#488
Conversation
getDeviceId() was being called before super.enabled = true in setup(), causing isEnabled() to return false and short-circuit the device ID initialization. Also adds posthog-android to the changeset for a proper minor version bump.
Contributor
posthog-android Compliance ReportDate: 2026-04-13 20:42:45 UTC ✅ All Tests Passed!0/0 tests passed |
marandaneto
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getDeviceId()call aftersuper.enabled = trueinsetup()soisEnabled()doesn't short-circuit device ID initializationposthog-androidto the changeset for a proper minor version bumpFollow-up to #481 — these two issues were flagged in review but missed before merge.