feat(alerts): new charts to show alert history#54932
Open
feat(alerts): new charts to show alert history#54932
Conversation
Contributor
Query snapshots: Backend query snapshots updatedChanges: 1 snapshots (1 modified, 0 added, 0 deleted) What this means:
Next steps:
|
MattPua
added
the
update-snapshots
Contributor
|
Size Change: +38.6 kB (+0.03%) Total Size: 130 MB
ℹ️ View Unchanged
|
pauldambra
reviewed
Apr 16, 2026
Contributor
Prompt To Fix All With AIThis is a comment left during a code review.
Path: frontend/src/lib/components/Alerts/alertLogic.ts
Line: 225-231
Comment:
**Page count duplicated from selector**
`alertHistoryTablePageForward` re-computes the page count inline (lines 228–229) rather than consuming the already-defined `alertHistoryTablePageCount` selector. This violates OnceAndOnlyOnce — if the formula ever changes it must be updated in two places.
```suggestion
alertHistoryTablePageForward: () => {
const tablePage = values.checksHistoryTablePage
const pageCount = values.alertHistoryTablePageCount
if (tablePage >= pageCount) {
return
}
```
How can I resolve this? If you propose a fix, please make it concise.Reviews (1): Last reviewed commit: "types" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
|
⏭️ Skipped snapshot commit because branch advanced to The new commit will trigger its own snapshot update workflow. If you expected this workflow to succeed: This can happen due to concurrent commits. To get a fresh workflow run, either:
|
![posthog[bot]](https://avatars.githubusercontent.com/in/1203049?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🔍 QA Team Review Report
| Key | Value |
|---|---|
| Verdict | 💬 APPROVE WITH NITS |
| Risk | 🟡 MEDIUM |
| Agents | 🔒 security 🔄 reliability ⚡ performance 🎨 frontend 📊 data-integrity ✏️ copy 🧑💻 generalist-a 🕵️ generalist-b |
Well-structured feature with proper flag gating, good test coverage, and clean kea architecture. The convergent findings around unbounded offset and unconditional COUNT are worth addressing before broader rollout but are not merge-blockers given the feature flag protection and 14-day check retention cap.
Full report in inline comments below.
Contributor
|
🎭 Playwright report · View test results →
These issues are not necessarily caused by your changes. |
Contributor
|
⏭️ Skipped snapshot commit because branch advanced to The new commit will trigger its own snapshot update workflow. If you expected this workflow to succeed: This can happen due to concurrent commits. To get a fresh workflow run, either:
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Contributor
|
⏭️ Skipped snapshot commit because branch advanced to The new commit will trigger its own snapshot update workflow. If you expected this workflow to succeed: This can happen due to concurrent commits. To get a fresh workflow run, either:
|
Contributor
|
⏭️ Skipped snapshot commit because branch advanced to The new commit will trigger its own snapshot update workflow. If you expected this workflow to succeed: This can happen due to concurrent commits. To get a fresh workflow run, either:
|
Contributor
Visual regression: Storybook UI snapshots updatedChanges: 24 snapshots (0 modified, 24 added, 0 deleted) What this means:
Next steps:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Alert editors only exposed check history as 5 rows in a table, which makes it harder to see how values (or anomaly scores) evolved over time relative to thresholds.
Changes
CleanShot.2026-04-16.at.16.10.01.mp4
How did you test this code?
Locally
new tests
Storybook.
Publish to changelog?
no
Docs update
No docs change. Add
skip-inkeep-docson the PR if you want to suppress the Inkeep docs bot.LLM context
Co-authored with Cursor. Serializer/viewset changes required
hogli build:openapi(frontend alerts schemas, MCP generated alerts tools). Feature flag key in code:alerts-history-chart(FEATURE_FLAGS.ALERTS_HISTORY_CHART).