Skip to content

CI: Import ../ai/CLAUDE.md instead of linking to it - #48

Merged
jnasbyupgrade merged 2 commits into
Postgres-Extensions:masterfrom
jnasbyupgrade:adopt-ai-claude-import
Sep 8, 2026
Merged

CI: Import ../ai/CLAUDE.md instead of linking to it#48
jnasbyupgrade merged 2 commits into
Postgres-Extensions:masterfrom
jnasbyupgrade:adopt-ai-claude-import

Conversation

@jnasbyupgrade

Copy link
Copy Markdown
Contributor

A markdown link means an agent has to notice it and manually go read the file; an @-include auto-loads it into context the same way ~/.claude/CLAUDE.md already imports its own siblings. Mirrors pg_count_nulls PR #64's conversion of the same link.

A markdown link means an agent has to notice it and manually go read the
file; an @-include auto-loads it into context the same way ~/.claude/CLAUDE.md
already imports its own siblings. Mirrors pg_count_nulls PR #64's conversion
of the same link.
@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 0aa8176e-7c0a-43e3-9097-6170337c3f8e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

Code Review in progress

  • Gather context (PR diff, repo CLAUDE.md)
  • Review changed file (CLAUDE.md)
  • Post review findings

Branch

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

Claude finished @jnasbyupgrade's task in 2m 0s —— View job


Code Review

  • Gather context (PR diff, repo CLAUDE.md)
  • Review changed file (CLAUDE.md)
  • Post review findings

Diff reviewed (origin/master...HEAD, CLAUDE.md):

-See [`../ai/CLAUDE.md`](../ai/CLAUDE.md) (or
-https://github.com/Postgres-Extensions/ai/blob/main/CLAUDE.md if that path
-doesn't exist locally — clone it to `../ai/` per its own first instruction)
-and `../ai/PR.md` for cross-repo conventions (CI monitoring, PR/commit
-conventions, etc.) not restated here.
+@../ai/CLAUDE.md
+
+If `../ai/CLAUDE.md` doesn't exist locally (see
+https://github.com/Postgres-Extensions/ai), clone it now per its own
+first instruction, then re-read it — do not rely on the import above
+alone to have picked it up in that case.

Finding

The removed paragraph carried two references: ../ai/CLAUDE.md (now converted to an @-import, good) and ../ai/PR.md, explicitly called out for "cross-repo conventions (CI monitoring, PR/commit conventions, etc.) not restated here." The new paragraph drops the PR.md mention entirely — there is no @../ai/PR.md import, and no textual pointer to it anywhere else in the file.

Unless ../ai/CLAUDE.md itself now surfaces those PR.md conventions (can't confirm from this repo alone, since ../ai/ isn't checked out here), this looks like an unintentional regression: an agent working in this repo would no longer be told to consult ../ai/PR.md at all, even though the PR/commit and CI-monitoring conventions it holds are presumably still expected to be followed. The PR description only discusses the link→import conversion, not dropping this second reference, so it may not be deliberate.

Suggest either adding it back (e.g. @../ai/PR.md alongside the CLAUDE.md import, or a sentence pointing to it) or confirming in the PR that ../ai/CLAUDE.md already covers/imports it, in which case this is a non-issue.

Fix this →

Other notes

  • The @-import syntax and fallback-clone instructions read correctly and match the stated intent (auto-load into context vs. requiring an agent to notice and follow a link).
  • No other files changed; nothing else to review.

Branch

@jnasbyupgrade
jnasbyupgrade merged commit 9c5fbda into Postgres-Extensions:master Sep 8, 2026
21 checks passed
@jnasbyupgrade
jnasbyupgrade deleted the adopt-ai-claude-import branch September 8, 2026 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant