Skip to content

Rename PG_TLE_BUILD_VERSION back to PGTLE_VERSION (#22) - #65

Open
jnasbyupgrade wants to merge 1 commit into
Postgres-Extensions:masterfrom
jnasbyupgrade:fix-22-pgtle-version-rename
Open

Rename PG_TLE_BUILD_VERSION back to PGTLE_VERSION (#22)#65
jnasbyupgrade wants to merge 1 commit into
Postgres-Extensions:masterfrom
jnasbyupgrade:fix-22-pgtle-version-rename

Conversation

@jnasbyupgrade

Copy link
Copy Markdown
Contributor

pgxntool#78 is fixed and synced (2.3.0 renamed the colliding Makefile variable to PGXNTOOL_PGTLE_VERSION), so the workaround and its explanatory comment are no longer needed.

Closes #22

…s#22)

pgxntool#78 is fixed and synced (2.3.0 renamed the colliding Makefile
variable to PGXNTOOL_PGTLE_VERSION), so the workaround and its
explanatory comment are no longer needed.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Sep 8, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 41a01c77-97db-4cc7-95be-9b9586f0aca4

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

Claude finished @jnasbyupgrade's task in 1m 13s —— View job


Code Review

  • Gather context (PR diff, CLAUDE.md conventions)
  • Review changed file: .github/workflows/ci.yml
  • Post review feedback

Summary: This renames the CI env var PG_TLE_BUILD_VERSION back to PGTLE_VERSION in two jobs (pg-tle-test and the one around line 826) and removes the comment explaining the original workaround.

Verification of the premise: I confirmed against the vendored pgxntool/ copy in this repo that the underlying collision is indeed fixed upstream — pgxntool/base.mk now uses PGXNTOOL_PGTLE_VERSION (not PGTLE_VERSION) for its own make pgtle version-limiting variable (pgxntool/base.mk:444-452), and pgxntool/HISTORY.asc documents the rename with an explicit reference to issue #78. So this CI job's env var name no longer collides with pgxntool's Makefile variable, and the workaround/comment really are safe to remove.

Consistency check: I grepped the whole repo and ci.yml for both PG_TLE_BUILD_VERSION and PGTLE_VERSION — every reference (env declarations, step names, and the git clone --branch v${{ env.PGTLE_VERSION }} line) was updated consistently in both jobs, and no stale references to the old name remain anywhere.

No issues found — the change is correct, minimal, and matches its stated rationale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename PG_TLE_BUILD_VERSION back to PGTLE_VERSION once pgxntool#78 is fixed

1 participant