Update internal-variable references for pgxntool's _PGXNTOOL_ rename - #72
Merged
jnasbyupgrade merged 1 commit intoSep 8, 2026
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 task
jnasbyupgrade
marked this pull request as ready for review
September 8, 2026 20:32
jnasbyupgrade
added a commit
to Postgres-Extensions/pgxntool
that referenced
this pull request
Sep 8, 2026
- Renamed 5 pure-internal-plumbing Make variables from a bare `PGXNTOOL_` prefix (which reads like a supported override point) to `_PGXNTOOL_...`: `PGXNTOOL_BASE_MK_INCLUDED`, `PGXNTOOL_CONTROL_FILES`, `PGXNTOOL_EXTENSIONS`, `PGXNTOOL_INSTALL_SCHEDULE`, and `_CHECK_STALE_EXPECTED_SCRIPT` (renamed too, for `_PGXNTOOL_` consistency). - `PGXNTOOL_DIR` deliberately left as-is: present since Release 0.1 (2016), referenced across `base.mk` plus 4 shell scripts — highest-risk name in the framework to touch, out of scope here. - HISTORY.asc updated (new STABLE section, `Issues fixed in this release: #87`). Fixes #87. Paired with Postgres-Extensions/pgxntool-test#72 for the corresponding test/doc updates.
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Add tests/updates for pgxntool commit e807c46 (renamed 5 internal-only Make variables to the `_PGXNTOOL_` shape): - `PGXNTOOL_BASE_MK_INCLUDED`, `PGXNTOOL_CONTROL_FILES`, `PGXNTOOL_EXTENSIONS`, `PGXNTOOL_INSTALL_SCHEDULE` -> `_PGXNTOOL_*` - `_CHECK_STALE_EXPECTED_SCRIPT` -> `_PGXNTOOL_CHECK_STALE_EXPECTED_SCRIPT` Updated the only test-suite references to these variables by name: - `test/standard/make-test.bats`: 3 sites passing `_CHECK_STALE_EXPECTED_SCRIPT` on the `make` command line to stub the script - `test/sequential/04-pgtle.bats`: `make print-PGXNTOOL_CONTROL_FILES` debug check - `test/lib/helpers.bash` and `CLAUDE.md`: updated comments/prose documenting the naming convention itself, including calling out `PGXNTOOL_DIR` as the deliberate, age-based exception left unrenamed Co-Authored-By: Claude <noreply@anthropic.com>
jnasbyupgrade
force-pushed
the
issue-87-internal-var-naming
branch
from
September 8, 2026 21:00
396050a to
06cca98
Compare
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_PGXNTOOL_shape, fixing pgxntool#87).test/standard/make-test.bats(3 sites stubbing_CHECK_STALE_EXPECTED_SCRIPT),test/sequential/04-pgtle.bats(make print-PGXNTOOL_CONTROL_FILES).test/lib/helpers.bashandCLAUDE.mdprose documenting the naming convention itself.Test plan