win_psDscAdapter and psDscAdapter PScredentials fix for passing username and password

[mimachniak]

PR Summary

• I change creating object System.Management.Automation.PSCredential for ScriptBase resources base on Get-Credential parameters
• Added dsc.yaml test file for ScriptBased DSC

PR Context

Fix using ScriptBased DSC resources when is reguired to use parameters with Get-Credentials

[mimachniak]

@microsoft-github-policy-service agree

@mimachniak please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

• (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@microsoft-github-policy-service agree

• (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

[Gijsreyn]

@mimachniak - as I have already spoken with you on socials, is this perhaps also possible for class-based DSC resources (both in the 5.1 and 7.0 adapter)? Can you also include a testcase that covers this change?

[mimachniak]

Yes I working o it

[mimachniak]

@Gijsreyn , @SteveL-MSFT - I added in test folder yaml's that are using TestClass for validation using PSCredentials, I tested on version 5.1 and 7 of PowerShell

[Gijsreyn]

@mimachniak - can it be tested inside the powershellgroup.config.tests.ps1 and win_powershellgroup.tests.ps1 or is it already covered?

[mimachniak]

@mimachniak - can it be tested inside the powershellgroup.config.tests.ps1 and win_powershellgroup.tests.ps1 or is it already covered?

I will add today, I added yaml files for running test

[mimachniak]

@mimachniak - can it be tested inside the powershellgroup.config.tests.ps1 and win_powershellgroup.tests.ps1 or is it already covered?

I added unit test and validation in file in powershellgroup.config.tests.ps1

[mimachniak]

I added test for 5.1 as well

[SteveL-MSFT]

@mimachniak Thanks for adding the test resource, but there isn't a Pester test using it yet?

[mimachniak]

@SteveL-MSFT I will add test today

[mimachniak]

@SteveL-MSFT I will add test today

Test added and minor fix to adapter as well

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[mimachniak]

@SteveL-MSFT I see that I need to add to test in script base module creation, I will do it today

[SteveL-MSFT]

@mimachniak Some Windows Pester tests failed in CI, can you take a look at those? Also look over the Copilot feedback and see if any should be addressed. Thanks!

[mimachniak]

@mimachniak Some Windows Pester tests failed in CI, can you take a look at those? Also look over the Copilot feedback and see if any should be addressed. Thanks!

Yes I'm fixing this as well

[mimachniak]

@SteveL-MSFT - fix all co-pilot subjects, and added unit test for script base resources

[mimachniak]

@SteveL-MSFT - fix all co-pilot subjects, and added unit test for script base resources

Can you allow to run checks ?

[mimachniak]

@SteveL-MSFT - fix all co-pilot subjects, and added unit test for script base resources

Can you allow to run checks ?

Need one more time, I have mispel in test file

[mimachniak]

@SteveL-MSFT please run job for test I think this time all test should be ok

[mimachniak]

@SteveL-MSFT please run job for test I think this time all test should be ok

Can you run check

[mimachniak]

@SteveL-MSFT build was failing on some clippy I update branch, can you allow to run check.

[mimachniak]

@SteveL-MSFT don't know why this got error, rest looks ok - some fix in class base test is added

BUILD:   Cleaning up
BUILD:   Cleaning up::Restoring rust environment
VERBOSE: Resetting Rust environment...
VERBOSE: No Rust environment variables defined
VERBOSE: Reset rust environment
VERBOSE: No Rust environment variables defined
Finished build script
Write-Error: D:\a\_temp\e59c5db3-f145-4208-a7bd-5c0daaf21951.ps1:8
Line |
   8 |  ./build.ps1 @params -PesterTestGroup extensions
     |  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | An error occurred: Install-PSResource: 'Response status code does not indicate success: 999.' Request sent:
     | 'https://www.powershellgallery.com/api/v2/FindPackagesById()?$filter=Id+eq+%27PSDesiredStateConfiguration%27+and+Normali zedVersion+eq+%272.0.7%27&$inlinecount=allpages&id=%27PSDesiredStateConfiguration%27'
Error: Process completed with exit code 1.

[mimachniak]

@SteveL-MSFT don't know why this got error, rest looks ok - some fix in class base test is added

BUILD:   Cleaning up
BUILD:   Cleaning up::Restoring rust environment
VERBOSE: Resetting Rust environment...
VERBOSE: No Rust environment variables defined
VERBOSE: Reset rust environment
VERBOSE: No Rust environment variables defined
Finished build script
Write-Error: D:\a\_temp\e59c5db3-f145-4208-a7bd-5c0daaf21951.ps1:8
Line |
   8 |  ./build.ps1 @params -PesterTestGroup extensions
     |  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | An error occurred: Install-PSResource: 'Response status code does not indicate success: 999.' Request sent:
     | 'https://www.powershellgallery.com/api/v2/FindPackagesById()?$filter=Id+eq+%27PSDesiredStateConfiguration%27+and+Normali zedVersion+eq+%272.0.7%27&$inlinecount=allpages&id=%27PSDesiredStateConfiguration%27'
Error: Process completed with exit code 1.

I merge again with main can you run checks

[SteveL-MSFT]

@SteveL-MSFT don't know why this got error, rest looks ok - some fix in class base test is added

BUILD:   Cleaning up
BUILD:   Cleaning up::Restoring rust environment
VERBOSE: Resetting Rust environment...
VERBOSE: No Rust environment variables defined
VERBOSE: Reset rust environment
VERBOSE: No Rust environment variables defined
Finished build script
Write-Error: D:\a\_temp\e59c5db3-f145-4208-a7bd-5c0daaf21951.ps1:8
Line |
   8 |  ./build.ps1 @params -PesterTestGroup extensions
     |  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     | An error occurred: Install-PSResource: 'Response status code does not indicate success: 999.' Request sent:
     | 'https://www.powershellgallery.com/api/v2/FindPackagesById()?$filter=Id+eq+%27PSDesiredStateConfiguration%27+and+Normali zedVersion+eq+%272.0.7%27&$inlinecount=allpages&id=%27PSDesiredStateConfiguration%27'
Error: Process completed with exit code 1.

I merge again with main can you run checks

That error looks to be an issue from PSGallery