Repository navigation
Add structured handling for settings - #1690
Open
Mikey Lombardi (He/Him) (michaeltlombardi) wants to merge 8 commits into
Open
Mikey Lombardi (He/Him) (michaeltlombardi) wants to merge 8 commits into
Mikey Lombardi (He/Him) (michaeltlombardi) wants to merge 8 commits into
Conversation
Mikey Lombardi (He/Him) (michaeltlombardi)
force-pushed
the
gh-1081/main/settings-schematization
branch
2 times, most recently
from
October 9, 2026 19:25
a96b570 to
8ab7650
Compare
Mikey Lombardi (He/Him) (michaeltlombardi)
requested a balanced review from Copilot
October 9, 2026 20:48
Copilot started reviewing on behalf of
Mikey Lombardi (He/Him) (michaeltlombardi)
October 9, 2026 20:49
Mikey Lombardi (He/Him) (michaeltlombardi)
force-pushed
the
gh-1081/main/settings-schematization
branch
from
October 13, 2026 16:30
8ab7650 to
577e0af
Compare
Mikey Lombardi (He/Him) (michaeltlombardi)
requested a balanced review from Copilot
October 13, 2026 16:32
Copilot started reviewing on behalf of
Mikey Lombardi (He/Him) (michaeltlombardi)
October 13, 2026 16:33
Mikey Lombardi (He/Him) (michaeltlombardi)
force-pushed
the
gh-1081/main/settings-schematization
branch
3 times, most recently
from
October 14, 2026 15:16
bc1cbd2 to
5b023ee
Compare
Mikey Lombardi (He/Him) (michaeltlombardi)
marked this pull request as ready for review
October 14, 2026 16:36
Prior to this change, DSC accepted settings from multiple sources and scopes but retrieved those settings adhoc when needed. The settings were not structured or consistently retrieved and resolved. This change starts the work for PowerShell#1081 by: - Adding a new `settings` module to `dsc-lib` to contain the structured cascading hierarchy of settings. - Defining reusable patterns and guidance for maintaining and extending the settings that DSC recognizes. - Providing stubs for writing rust tests where we need to define fixtures to replicate reading from files and environment variables.
This change adds the rust integration tests for the `settings` module. It also introduces helper macros for validating DSC repo schemas and updates the schema generation tests to cover the newly defined types.
Prior to this change, the implementation for `idiomaticize_string_enum` incorrectly used the `enumMarkdownDescriptions` keyword instead of the correct `markdownEnumDescriptions` keyword. This change fixes the implementation and tests.
Prior to this change, the `schema_i18n` macro only supported passing a single string literal as the input value. This made it impossible to correctly construct calls to the macro when needing to compose the dotpath through a macro or dynamic lookup. This change: - Enables the macro to accept multiple string literals or an arbitrary expression. - Adds documentation to the macro. - Adds the missing header comments to the source file.
Prior to this change, the i18n tests would find any apparent usage of the `t!` macro in a file. This unfortunately also included documentation comments, which raised errors for undefined translation strings that are not expected to be defined. This change strips lines that begin with a comment before searching for the expected patterns.
Mikey Lombardi (He/Him) (michaeltlombardi)
force-pushed
the
gh-1081/main/settings-schematization
branch
from
October 15, 2026 15:00
5b023ee to
2b291bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR defines the structure and handling for initializing settings from multiple scopes.
This implementation defines a model for DSC's settings to support defining settings in multiple scopes. Settings defined in higher priority scopes supercede those from lower scopes. The scopes are, in priority order from lowest to highest:
dscroot command.The implementation supports the previously defined settings structure, loading settings from each scope, and resolving the settings to enable consistently accessing the DSC settings as needed.
This implementation does not wire the new settings structures through the library and CLI code, it only completes the definition work and provides unit/integration testing for the new code.
PR Context
Part of #1081 to enable better UX for defining and retrieving DSC settings and to support a more maintainable expansion of settings over time.