Skip to content

Fix flaky Emacs e2e test: replace fixed sleep with diagnostic polling loop #2276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andyleejordan merged 2 commits into from
Apr 8, 2026
+5 −1
Merged

Fix flaky Emacs e2e test: replace fixed sleep with diagnostic polling loop #2276

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e422af1
Initial plan
Copilot Apr 8, 2026
f124e87
Fix timing issue in Emacs test by polling for flymake diagnostics
Copilot Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion test/emacs-test.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,12 @@
(let ((lsp (eglot-current-server)))
(should (string= (eglot--project-nickname lsp) "PowerShellEditorServices"))
(should (member (cons 'powershell-mode "powershell") (eglot--languages lsp))))
(sleep-for 5) ; TODO: Wait for "textDocument/publishDiagnostics" instead
(flymake-start)
;; Wait for diagnostics to arrive instead of sleeping a fixed duration
(let ((deadline (time-add (current-time) 30)))
(while (and (time-less-p (current-time) deadline)
(null (flymake-diagnostics)))
(sleep-for 0.5)))
(goto-char (point-min))
(flymake-goto-next-error)
(should (eq 'flymake-warning (face-at-point))))))
Expand Down