This repository was archived by the owner on Jan 21, 2021. It is now read-only.
Bug fixes#257
Open
mwkoehler wants to merge 4 commits intoPowerShellMafia:masterfrom
Open
Conversation
…dates as c:\ is always modifiable and not relevant. This only comes up with parameters being misread as paths.
…sername, Changed or NewName is not blank.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found a few cases that were not handled and either produced false positives or did not handle an exception.
Get-ModifiablePath treats service parameters like paths causing c:\ to be reported as writable. It also did not handle System.UnauthorizedAccessException. There is still a false positive for services that take a parameter for a writable path to write data to.
Get-CurrentUserTokenGroupSid tries to use empty SID values causing exceptions.
local:Get-GPPInnerFields reports xml files that have no credentials. Added check to not emit result in this case.