Add integration test for parentChain dep chain messaging#148
Open
eliotmcintire wants to merge 3 commits intodevelopmentfrom
Open
Add integration test for parentChain dep chain messaging#148eliotmcintire wants to merge 3 commits intodevelopmentfrom
eliotmcintire wants to merge 3 commits intodevelopmentfrom
Conversation
Creates a dummy package tarball (dummypkgwithpryr) with Imports: pryr, places it in the Require file cache, then calls pkgDep() to verify that the "not on CRAN" message for pryr includes "(required by: dummypkgwithpryr)". Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… repos - Integration test: builds a minimal file:// CRAN repo containing dummypkgwithpryr (Imports: pryr), calls pkgDep(), and asserts that the 'not on CRAN' message for pryr includes '(required by: dummypkgwithpryr)' - Bug fix in available.packagesCached: was prepending 'https://' to any repo not starting with 'http', which corrupted file:// URLs. Fixed to only prepend to bare domain names (no protocol). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Avoid file:// CRAN repo (which triggers offline mode on R 4.2 Windows). Instead mock joinToAvailablePackages to inject VersionOnRepos + Imports for dummypkgwithpryr, letting the full recursive pkgDep code path run without any file or network access for the dummy package itself. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dummypkgwithpryr_1.0.tar.gzwithImports: pryrin its DESCRIPTIONgetArchiveDESCRIPTIONcan read it without network accesspkgDep("dummypkgwithpryr")and asserts that the "not on CRAN" message forpryrincludes(required by: dummypkgwithpryr)— exercising the fullparentChainthreading throughgetPkgDeps → getDeps → getDepsNonGH → pkgDepCRANTest plan
pryr(archived on CRAN) triggers the expected chained message🤖 Generated with Claude Code