feat: Add worker health check and auto-restart logic#119
Open
vominh1919 wants to merge 1 commit into
Open
Conversation
Fixes PrimeIntellect-ai#41 - Add _is_worker_alive() method to check if worker process is still running - Add _restart_worker() method to cleanly restart crashed workers - Terminates old worker process - Clears input queue of stale items - Fails pending validations with CRASHED status - Starts new worker process - Add _restart_lock to prevent concurrent restart attempts - Add _pending_validations dict to track in-flight validations - Update validate_entries() to: - Check worker health before starting validation - Monitor worker health while waiting (5s intervals) - Handle worker crashes gracefully - Update validate_grouped_entries() with same worker health monitoring - Add logging for worker PID on startup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #41
Problem
If the validation engine worker thread crashes (e.g., due to a key error or OOM), there was no recovery mechanism. The engine would fail permanently.
Solution
_is_worker_alive()method to check if worker process is still running_restart_worker()method to cleanly restart crashed workers:CRASHEDstatus_restart_lockto prevent concurrent restart attempts_pending_validationsdict to track in-flight validationsvalidate_entries()andvalidate_grouped_entries()to:CRASHEDstatusTesting
The changes are backwards compatible and maintain the existing API.