test: cover getUpstashConfig missing-env and empty-string cases (#3031)#3192
Open
aaniya22 wants to merge 1 commit into
Open
test: cover getUpstashConfig missing-env and empty-string cases (#3031)#3192aaniya22 wants to merge 1 commit into
aaniya22 wants to merge 1 commit into
Conversation
|
Thanks for your first PR on DevTrack! 🎉 A maintainer will review it within 48 hours. While you wait:
If you find DevTrack useful, a ⭐ star on the repo is always appreciated — it helps the project grow and attract more contributors! |
GSSoC Label Checklist 🏷️@Priyanshu-byte-coder — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds test coverage for
getUpstashConfig()'s two untested branches — both env vars set, and either env var being an empty string — closing the gap identified in the issue.Closes #3031
Type of Change
What Changed
getUpstashConfig returns { url, token } when both env vars are settotest/upstash-rest.test.mjsgetUpstashConfig returns null when either env var is an empty stringtotest/upstash-rest.test.mjssrc/lib/upstash-rest.tsitself — test-only PRHow to Test
node --test test/upstash-rest.test.mjsExpected result: All tests pass, including the two new cases covering
getUpstashConfig's previously-untested branches.Screenshots / Recordings
Not applicable — test-only change, no UI impact.
Checklist
console.log, debug code, or commented-out blocksnpm run lintpasses locallynpm run type-check)Accessibility (UI changes only)
Not applicable — no UI impact.
Additional Context
Issue #3031 asked for a new
test/upstash-rest.test.tsusing Vitest, but atest/upstash-rest.test.mjsusing Node's built-innode:testrunner already exists and covers most ofupstash-rest.ts(includingupstashRateLimitFixedWindowandupstashTryAcquireLock). Rather than create a second, competing test file for the same module in a different framework, I extended the existing file with the two specificgetUpstashConfigscenarios the issue called out that weren't yet covered. Happy to convert to a standalone Vitest file instead if that's preferred — just let me know and I'll follow up.