test: add non-mutation coverage for mergeCommitCounts (#2988)#3195
Open
aaniya22 wants to merge 1 commit into
Open
test: add non-mutation coverage for mergeCommitCounts (#2988)#3195aaniya22 wants to merge 1 commit into
aaniya22 wants to merge 1 commit into
Conversation
GSSoC Label Checklist 🏷️@Priyanshu-byte-coder — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds one missing test case to
test/developer-persona.test.ts: verifies thatmergeCommitCountsdoes not mutate its input objects when merging overlapping dates, as called out in issue #2988.Closes #2988
Type of Change
What Changed
test/developer-persona.test.ts— added a new test in themergeCommitCountsdescribe block:"should not mutate the original input objects". It snapshots both input maps before callingmergeCommitCounts(a, b)and asserts they're unchanged afterward.How to Test
pnpm install(use--ignore-scriptsif the optionaltree-sitternative build fails on your machine — it's unrelated to this change).npx vitest run test/developer-persona.test.ts.Expected result: All 26 tests in the file pass, including the new non-mutation test for
mergeCommitCounts.Screenshots / Recordings
Not applicable — this is a test-only change with no UI impact.
Checklist
console.log, debug code, or commented-out blocksnpm run lintpasses locallynpm run type-check)Accessibility (UI changes only)
Not applicable — no UI changes.
Additional Context
Most of the coverage requested in #2988 —
calculateStreaks,formatDurationHours,choosePersonaCandidate,mergeCommitCounts(sum behavior), andmergeSignals— already exists intest/developer-persona.test.tsonmain. This PR adds the one gap I found while reviewing: an explicit assertion thatmergeCommitCountsdoesn't mutate its inputs, which the issue mentions but wasn't previously tested. Flagging this so reviewers aren't surprised the diff is small relative to the issue's original scope.