test: add mocked crypto.subtle coverage for decryptTokenEdge (#2990)#3196
Open
aaniya22 wants to merge 1 commit into
Open
test: add mocked crypto.subtle coverage for decryptTokenEdge (#2990)#3196aaniya22 wants to merge 1 commit into
aaniya22 wants to merge 1 commit into
Conversation
GSSoC Label Checklist 🏷️@Priyanshu-byte-coder — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds two missing test cases to
test/crypto-edge.test.ts: mockingglobalThis.crypto.subtleviavi.stubGlobalto verifydecryptTokenEdgereturnsnullwhencrypto.subtle.decryptthrows, and to assert the exact parameters passed tocrypto.subtle.importKeyandcrypto.subtle.decrypt, per issue #2990.Closes #2990
Type of Change
What Changed
test/crypto-edge.test.ts— added two tests to thedecryptTokenEdgedescribe block:"returns null when crypto.subtle.decrypt throws"— stubsglobalThis.crypto.subtlewithvi.stubGlobalsodecryptrejects, and asserts the function catches it and returnsnull."calls crypto.subtle.importKey and crypto.subtle.decrypt with the correct parameters"— stubscrypto.subtlewith spies and assertsimportKeyis called with"raw", a 32-byte key,{ name: "AES-GCM" },false,["decrypt"], anddecryptis called with{ name: "AES-GCM", iv: <12-byte Uint8Array>, tagLength: 128 }and the correctly-sized encrypted byte array.How to Test
pnpm install(use--ignore-scriptsif the optionaltree-sitternative build fails locally — unrelated to this change).npx vitest run test/crypto-edge.test.ts.Expected result: All 15 tests in the file pass, including the two new mocked-
crypto.subtletests.Screenshots / Recordings
Not applicable — test-only change, no UI impact.
Checklist
console.log, debug code, or commented-out blocksnpm run lintpasses locallynpm run type-check)Accessibility (UI changes only)
Not applicable — no UI changes.
Additional Context
Most of the coverage requested in #2990 (missing/invalid key, invalid hex/odd-length ciphertext, invalid IV length, successful decryption) already existed in
test/crypto-edge.test.tsonmain, using the real Web Crypto API end-to-end. This PR adds the two pieces the issue specifically asked for that weren't covered: mockingglobalThis.crypto.subtlewithvi.stubGlobal, and verifying the exact call parameters toimportKey/decrypt. Flagging this so the diff's scope relative to the issue is clear.