fix(security): resolve IPv4 signed 32-bit integer overflow in SSRF pr…#3199
Open
desireddymohithreddy0925 wants to merge 5 commits into
Open
Conversation
GSSoC Label Checklist 🏷️@Priyanshu-byte-coder — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
… and pnpm version from 11 to 9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves a critical Server-Side Request Forgery (SSRF) bypass by fixing a signed 32-bit integer overflow in the IP parsing logic.
Closes #3118
Type of Change
What Changed
ipToNumberutility insrc/lib/ssrf-protection.tsto construct IP numbers using safe unsigned multiplication (or>>> 0) instead of signed bitwise shifting.192.168.x.xand172.16.x.xfrom wrapping into negative numbers, ensuring they are properly detected and blocked by the private IP range checks.How to Test
192.168.1.1to theisPrivateIPcheck (or attempt to configure a webhook pointing to that IP).isPrivateIPreturnstrue).172.16.0.1and verify it is also blocked.Expected result: The vulnerability is patched and requests to internal network services are properly blocked.
Screenshots / Recordings
(Not applicable for this backend security fix)