Repository navigation
ci: install Rust with rustup in CI and release builds, as the shared template does - #31
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces
dtolnay/rust-toolchainwith plainrustup, which every GitHub-hosted runner image already carries. This follows Project-Colony-Resources 7247b81:templates/sign-and-publish-caller.ymlnow installs Rust this way, anddesign/dependencies.mdsays CI should. One fewer third-party action to pin, and no master-commit pin that Dependabot cannot move.What changed
release.yml, build leg: theInstall Ruststep is now the template's step, verbatim (shell: bash,rustup toolchain install stable --profile minimal --no-self-update,rustup default stable,rustup target add ${{ matrix.target }}). Everything Spotter does differently from the template stays as it was: theTAGenv, apt dependencies,--locked, asset names, colony.json validation, smoke tests, the Intel macOS architecture check and the Windows version-resource check. The sign-and-publish pin stays at619460f.ci.yml, Check job: installs stable with--component clippy,rustfmt,shell: bashso the same step runs on the Linux, Windows and macOS legs.ci.yml, MSRV job: installs 1.90 the same way and makes it the default. Spotter has norust-toolchain.toml, so nothing overrides it.Verification
dtolnayreference is left in the repository.rustup target add.