Repository navigation
fix: keep the webview profile in the cache folder and the Preferences categories on the left in the phone layout - #49
Merged
Conversation
…stead of literals
… wiring main.rs setup now only wires the store, the window and the handlers; the legacy copy and the legacy_storage_imported decision live in migrate::open_store, with a test. The README folder table keeps the Data row, marked not used, so it matches the folders the About page lists.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the conformance gaps the last audit left open (DEP-1, LAY-7, FS-1, FS-5, ORG-9, SET-1, SET-2, SET-3, SET-11).
Folders and privacy
legacy_storage_imported), the profile goes to<cache>/Colony/orCAL/webviewon Linux and Windows instead of the data folder. orCAL keeps nothing of its own there, so it can be rebuilt.paths::cache_dir()is new and creates the folder.paths::data_dir()lost its last caller and is removed;locate::data_dirstays for the About page..incognito(true). wry 0.57 then usesWKWebsiteDataStore::nonPersistentDataStore, and nothing is written to~/Library/WebKit. The branch is a runtimecfg!, so no code is dead under clippy on any OS.<data>/webviewfolder is not deleted in the release that moves it (filesystem.md). The README says it can be deleted by hand..migratedmarker in the settings folder, which records where older settings were looked for. The webview row and the folder table now say cache folder on Linux and Windows, and in memory on macOS.Layout
open_main_windowmoves fromsrc/main.rstosrc/window_state.rs, which already owns the main window.main.rskeepsmain(), the--versioncheck and the Builder wiring. The legacy copy and thelegacy_storage_importeddecision move from the setup closure tomigrate::open_store, with a test, so setup only wires the store, the window and the handlers.Preferences page
calc(112px * var(--font-scale))wide and capped at 40% of the window by the shared rule. Long names break across lines (hyphens: auto) instead of squeezing the content.contrast_on()ends) were literal colours inbase.cssandtheme.js. They are now generated tokens in Project-Colony-Resources (refactor(tokens): generate the contrast_on label colours and export them as --colony-ink and --colony-paper Project-Colony-Resources#25):--colony-inkand--colony-paperincolony-accents.css. The vendored files are re-synced at c19a39d withscripts/sync-colony-tokens.sh.base.cssmaps--inkand--paperonto them, andtheme.jsreads them from the computed style. No literal colour is left insrc/uioutside the vendored files. The values are the old floats rounded to 8 bits (#14141a,#f7faff).Dependencies
cargo update: cc 1.8.0, smallvec 1.16.3, syn 3.0.9, unicode-ident 1.0.27, uuid 1.28.0.Verification
cargo fmt --check: clean.cargo clippy --locked --all-targets -- -D warningson Linux: clean.cargo test --lockedforpaths::,window_state::,migrate::andtests::: 49 passed. After the review fixes:cargo test --locked migrate::, 5 passed, and clippy clean again.node --checkon the changed module, and the vendoredthemes.jsonparses (src/i18n.rsembeds it).git grepfinds no hex,rgb()orcolor(srgb ...)colour insrc/uioutsidevendor/.