Repository navigation
fix(amdgpu): parse the SMC debugfs line that carries a program field - #162
Merged
Merged
Conversation
Newer kernels print "SMC feature version: 0, program: 7, firmware version: 0x07551300" in amdgpu_firmware_info. The regex required the firmware field right after the feature field, so SMC was dropped and TestFirmwareVersionConsistent compared the ioctl value against zero. Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: moezdil The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/kind bug
Newer kernels print
SMC feature version: 0, program: 7, firmware version: 0x07551300inamdgpu_firmware_info.fwVersionRerequired the firmware field right after the feature field, so the SMC entry was dropped andTestFirmwareVersionConsistentcompared the ioctl value (7551300) against zero. The regex now accepts an optionalprogram: N,field.Refs #38
Reproduced on an MI325X node (kernel 7.0): the consistency test failed before and passes now with the real debugfs mounted, and the new fixture test fails without the fix.
AI assistance was used for this PR.