Repository navigation
docs: drain the node before changing the operating mode - #165
Merged
Merged
Conversation
Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: moezdil The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind documentation
What this PR does / why we need it:
The docs only said a mode change needs a plugin restart. Switching between
cuandpartitionwith GPU Pods running leaves them under the old slot count and CU layout (reproduced on an MI325X VF: new Pods failed admission or were mis-scheduled before #159). This adds the drain, change, restart, verify and uncordon steps, mentions theAMDGPUModeChangedInUseevent from #160, and warns that upgrading from a partition-mode build older than #159 also needs a drained node.Which issue(s) this PR fixes:
Follow-up to #17, #159 and #160.
Special notes for your reviewer:
Docs only. The steps match what was run on the MI325X VF in the end-to-end mode-switch tests.
Does this PR introduce a user-facing change?:
No.
AI Disclosure:
AI-assisted, reviewed by the author.