Repository navigation
docs: record what the MI325X pass found and what it did not cover - #168
Merged
Merged
Conversation
Add the MI325X row to the tested hardware table, the chart values the configuration table was missing (reportNodeCapacity, deviceMemoryScaling, excludeGPUs, hipLogLevel) and the operating mode values in the chart README, the dmem kernel requirement, the k3s paths and the first-use image pull for muslFailClosed, the all-CUs default of a request without gpucores, and a short hardware verification section in the development guide. Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
hami-robot
Bot
added
the
kind/documentation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: moezdil The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/kind documentation
Brings the README and the docs in line with a verification pass on a real MI325X node: the MI325X row in the tested hardware table, the chart values the configuration table and the chart README were missing, the dmem kernel requirement (6.14 or newer), the k3s paths and the first-use image pull for
muslFailClosed, the fact that a request withoutamd.com/gpucoresgets all CUs, and a short hardware verification section in the development guide.Refs #161 #163 #164
AI assistance was used for this PR.