Skip to content

CodeQL and GPU Actions Update#8883

Open
ericspod wants to merge 2 commits into
Project-MONAI:devfrom
ericspod:actions_change
Open

CodeQL and GPU Actions Update#8883
ericspod wants to merge 2 commits into
Project-MONAI:devfrom
ericspod:actions_change

Conversation

@ericspod
Copy link
Copy Markdown
Member

Description

This fixes the reported failure of the GPU test action by adding a dispatch line to the "on" section, although this action is now disabled since it doesn't run tests currently. The CodeQL action is also updated to allow it to run.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
@ericspod ericspod requested a review from KumoLiu as a code owner May 28, 2026 17:49
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 28, 2026

📝 Walkthrough

Walkthrough

Two small workflow configuration updates: CodeQL scanning now installs wheel-stub and uses --no-build-isolation when installing requirements-dev.txt. GPU workflow explicitly enables manual dispatch via workflow_dispatch as its only active trigger.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed Title clearly describes the main changes: updates to CodeQL and GPU Actions workflows.
Description check ✅ Passed Description includes all required sections with adequate detail about changes, proper checklist completion, and clear reasoning for modifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/pythonapp-gpu.yml:
- Around line 4-13: The GPU job "GPU-quick-py3" is unconditionally skipped
because it contains "if: ${{ false }}"; remove or modify that if condition so
the job runs on manual workflow_dispatch (e.g., delete the line or replace with
a proper condition like checking github.event_name), and keep the existing
concurrency.group "build-gpu-${{ github.event.pull_request.number || github.ref
}}" as-is (it safely falls back to github.ref for workflow_dispatch).
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a7932395-d6db-4378-b71b-be4063d7d8ec

📥 Commits

Reviewing files that changed from the base of the PR and between dc0f59c and d71f027.

📒 Files selected for processing (2)
  • .github/workflows/codeql-analysis.yml
  • .github/workflows/pythonapp-gpu.yml

Comment thread .github/workflows/pythonapp-gpu.yml
@ericspod ericspod requested a review from garciadias May 28, 2026 18:49
@ericspod ericspod mentioned this pull request May 28, 2026
41 tasks
Signed-off-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant