CodeQL and GPU Actions Update#8883
Conversation
Signed-off-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
📝 WalkthroughWalkthroughTwo small workflow configuration updates: CodeQL scanning now installs wheel-stub and uses Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/pythonapp-gpu.yml:
- Around line 4-13: The GPU job "GPU-quick-py3" is unconditionally skipped
because it contains "if: ${{ false }}"; remove or modify that if condition so
the job runs on manual workflow_dispatch (e.g., delete the line or replace with
a proper condition like checking github.event_name), and keep the existing
concurrency.group "build-gpu-${{ github.event.pull_request.number || github.ref
}}" as-is (it safely falls back to github.ref for workflow_dispatch).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: a7932395-d6db-4378-b71b-be4063d7d8ec
📒 Files selected for processing (2)
.github/workflows/codeql-analysis.yml.github/workflows/pythonapp-gpu.yml
Signed-off-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
Description
This fixes the reported failure of the GPU test action by adding a dispatch line to the "on" section, although this action is now disabled since it doesn't run tests currently. The CodeQL action is also updated to allow it to run.
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.