Adding Bundle Schemas#100
Conversation
Signed-off-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughAdds nine JSON Schema files that define and evolve MONAI bundle/model metadata and network I/O descriptions across formats for general models, generators, LDMs, HF integration, and HoverNet. ChangesMONAI Bundle Metadata Schema Catalog
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@meta_schema_20220729.json`:
- Line 253: The "latent" property line uses a tab for indentation which is
inconsistent with the file's spaces; locate the "latent" key (the JSON property
"latent" shown in the diff) and replace the leading tab characters with the same
number of spaces used elsewhere in the file so indentation style matches the
rest of meta_schema_20220729.json.
- Line 168: Line 168 contains a tab character before the "latent" property which
is inconsistent with the file's spaces-based indentation; replace the tab with
the appropriate number of spaces to match the surrounding JSON nesting (use the
same 4-space multiples used elsewhere) so the "latent" key aligns with its
sibling properties and preserves consistent formatting.
In `@meta_schema_20240725.json`:
- Line 135: Fix the typo in the JSON description value for the metadata field
whose "description" currently reads "Version of NumPy the bundlewas generated
with." — update the string to "Version of NumPy the bundle was generated with."
so there is a space between "bundle" and "was" (edit the "description" property
in the same JSON object).
In `@meta_schema_hf_20250321.json`:
- Around line 3-17: The schema is missing a top-level "type" and "properties"
definition; update the JSON object that currently contains "required" to include
"type": "object" and a "properties" object that defines each required field
(e.g., "schema", "version", "changelog", "monai_version", "pytorch_version",
"numpy_version", "required_packages_version", "name", "task", "description",
"authors", "copyright", "huggingface_url") with appropriate simple types
(string/array/object as applicable) to match the other meta_schema files and
enforce field shapes.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: e5b59219-c720-4102-bece-4ea18906d79e
📒 Files selected for processing (8)
meta_schema_20220324.jsonmeta_schema_20220729.jsonmeta_schema_20240725.jsonmeta_schema_generator_20220718.jsonmeta_schema_generator_ldm_20230507.jsonmeta_schema_generator_ldm_20240318.jsonmeta_schema_hf_20250321.jsonmeta_schema_hovernet_20221124.json
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Signed-off-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
Signed-off-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
…monai.github.io into add_bundle_schema
Signed-off-by: Eric Kerfoot <17726042+ericspod@users.noreply.github.com>
Fixes Project-MONAI/MONAI#4048
This copies the existing schemas stored here into the website itself so these can be accessed through a shorter and permanent URL. The expectation is that the "schema" URL in
metadata.jsonfiles can use a shorter URL, eg."schema": "https://github.com/Project-MONAI/MONAI-extra-test-data/releases/download/0.8.1/meta_schema_20240725.json"becomes"schema": "https://project-monai.github.io/meta_schema_20240725.json".Summary by CodeRabbit